gh-141968: Use take_bytes in re._compiler #141995
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a copy going from bytearray to bytes.
6 tasks
vstinner
changed the title
picnixz
reviewed
Nov 28, 2025
Misc/NEWS.d/next/Library/2025-11-26-14-20-10.gh-issue-141968.W139Pv.rst
Outdated
Show resolved
Hide resolved
…139Pv.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Contributor
Author
|
@picnixz 👍 thanks for spotting the :func: vs :meth:, looking through these I have 6 other cases in the repository, would it make sense for me to make a PR to fix them? |
Member
|
Yes please do so. I'll accept the change. It's good to keep roles with the correct semantics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a copy going from bytearray to bytes.
cc: @serhiy-storchaka